8193017: Import freetype sources into OpenJDK source tree #709
Conversation
|
👋 Welcome back jvanek! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Co-authored-by: George Adams <[email protected]>
judovana
force-pushed
the
inTreeFreeType
branch
from
8657ac1 to
c2a41ed
Compare
|
@judovana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
judovana
changed the title
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
bot
added
the
backport
|
|
|
Good. The builds passed. I somehow do not see the issue in the tier1. I had run them on many OSes and many platforms, and all looks good. intel: Noni-ntels may look wilder, but there is no new failure. And they are mostly not running GUI anyway... |
|
Also all the full jtregs finished on all arches x osses I have handy. The |
|
Would be nice to have in-tree freetype as in later jdks As when person is not careful bundling freetype, it can end up linking against system hafrbuzz (which, in turn, has cyclic dependency on freetype). This may, in better case, fail the build. In worst case, build may seemingly look ok, but cause runtime linking error (in description), when run on newer OS (newer than build one). For reference, issue and workaround in temurin-build: Also (and older freetype such as |
openjdk
bot
added
the
approval
Are the failing jtregs. Do not seem to be related though Am also digging in 32windows time-outs, and can not see culprit. @zzambers any ideas? |
There are some unstable tests on x86 (32-bit) and probably unrelated to your PR. Segfault in |
|
btw. there is also issue with Windows x86 build jobs, where VS2010 installation hangs and jobs get cancelled. I have created PR for that. |
2 participants
Hi!
I had recently hit an issue with jdk8, which, if build on old system - eg el7, it can not run GUI application on newest system like f42 or similar:
As per investigations the issue is in duality of freetype, and is solved by
8193017: Import freetype sources into OpenJDK source treeThis is fully based on unfinished #318 , with smal lexception of rebase, and docs adaptation. The change in
doc/building.htmlis unluckily done manually, asmake update-build-docsis regenerating half of the universum. Is it desired? Is there some recomended version of pandoc to use?I had tested builds on windows and several linuxes, run full jtregs and checked the GUI works again. I can link full set of tests if needed (actually many of them are still running).
For record, I built by temurin build wrapper, which needed an change to adapt to this: adoptium/temurin-build#4287
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/709/head:pull/709$ git checkout pull/709Update a local copy of the PR:
$ git checkout pull/709$ git pull https://git.openjdk.org/jdk8u-dev.git pull/709/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 709View PR using the GUI difftool:
$ git pr show -t 709Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/709.diff
Using Webrev
Link to Webrev Comment